Ticket #36 (defect)
Opened 8 years ago
Last modified 8 years ago
.identifier() not used in db.py
Status: closed (fixed)
| Reported by: | mdt@emdete.de | Assigned to: | fumanchu |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Storage | Keywords: | |
| Cc: | Estimate (total hours): | ||
in db.py:931 the code of identifier() is copied instead of calling identifier(). this leads to problems for sm where identifier() is overloaded.
Change History
12/10/05 13:08:28: Modified by mdt@emdete.de
12/10/05 22:15:30: Modified by mdt@emdete.de
which was wrong...
it is missing in SQLDecompiler.column_name(self, tablename, name) and documented there. mmh. strange the tablename is already correct, the columnname is not.
why?
12/11/05 00:51:07: Modified by fumanchu
- status changed from new to assigned.
- component changed from Misc to Storage.
I think we should take the column_name method and have it call StorageManager?.escaped_identifier. The SM.identifier method should do the mapping, and return the column name without being wrapped in quotes; whereas escaped_identifier would quote it.
12/11/05 21:26:53: Modified by fumanchu
- status changed from assigned to closed.
- resolution set to fixed.
Fixed in [123].
same appears in arenas.py:247